I can help too, I don't mean to be just a complainer. Maybe its only a little more work.
Like i said, that first "patch" i threw up on the issue was just a quick stab. Instead of spending a lot of time analyzing what could/couldn't work I just took a quick stab in the chance that it would be simple (sometimes things like this work out), but it didn't: there is some more to do. I wish i had had more time to see it through back then before 4.0... On Sat, Nov 24, 2012 at 11:35 AM, Shai Erera <[email protected]> wrote: > I'm not arguing that it shouldn't be improved. It should. I'll try to take > a look at the tests again. > > Shai > > > On Sat, Nov 24, 2012 at 9:24 PM, Robert Muir <[email protected]> wrote: > >> >> >> On Sat, Nov 24, 2012 at 11:18 AM, Shai Erera <[email protected]> wrote: >> >>> Uwe, it's a good question :). The javadocs aren't that rich, and the >>> lucene-facet-examples.jar is created with the source code anyway ... >>> >>> Robert, I don't know maven enough but I do see this in >>> maven/lucene/facet/pom.xml.template: >>> >>> <configuration> >>> <sources> >>> <source>${module-path}/src/examples</source> >>> </sources> >>> </configuration> >>> >>> Does it mean that it's ok? >>> >> >> That may be ok in this particular example, but having this all in >> src/examples causes all kinds of questions. >> >> Do these files all contain apache license headers? I have no idea: >> because it has source code in a special place probably ignored by rat tasks. >> Will the examples work on any system regardless of its locale? I have no >> idea: its source is in a special place probably ignored by forbidden-api >> checker. >> >> And the list goes on and on. >> >> These are the reasons why I proposed a long time ago to remove the >> special case of lucene/src/demo and just make it an "ordinary module" with >> respect to the build system: otherwise it causes lots of bugs which always >> happened at release time. >> >> Finally for examples, it makes sense for them to be in the demo module >> anyway, as its configured in a special way to -linksource the examples into >> its javadocs, so that we can freely link to the precise versioned source >> code in that release (rather than things like svn locations, etc). >> >> >
