Of course I understand everything you say. We are just using Solr very intensively in my current project and we want to do big changes and when we make them we test them very thoroughly - so we are pretty sure they work as they are supposed to, but of course that is hard to see on your side, because we do not make that many tests in the Solr code, because that would make our contribs even bigger. But we test them thoroughly through our own test-suite. I have worked with Solr for a long time now and there is a million things that I (we in my project in general) would like to do, we just have a hard time to really get some progress - and my POs face turns green whenever I say that a feature/fix of some issue will require a Solr modification, because he knows how hard it is for us to get contribs through, and he knowns that the amount of time we use merging every time we want to get the newest code from Apache will increase by the amount of code we have different from yours.

I am a very experinced programmer with a long record as architect, designer, mentor etc. Is there a chance that I could become committer? You will end up happy - and so will I! :-)

Regards, Per Steffensen

Mark Miller skrev:
On Mon, Nov 26, 2012 at 9:55 AM, Per Steffensen <[email protected]> wrote:
Well I would like to jump in with respect to making support for running
several shards of the same collection on the same instance, it is just so
damn hard to get you to commit stuff :-)

A lot of the problem is time limitations for me personally. Every day
I go to sleep late wishing I could stay up just a little later :) I
never get everything I want done and I have a back log list of things
I'm interested in a mile long. So I sympathize, but I'm stretched thin
personally.

I do think though, if you look at CHANGES.txt, you will see that I do
commit a lot of other peoples patches! They just tend to be targeted
things that are relatively easy to digest. Also, things that are on my
itch list.

The main patches you have supplied so far are quite large! And touch
areas that involve other committers. Large patches and multiple
parties do not generally do well as we have mentioned in the past. It
depends on the committers, their time, their agenda, their itch list,
timing, etc.

I wouldn't give up trying to contribute though. Many of the things
tied up in your larger issues are things I'd like to get too. Once or
twice I've already gone into your work to 'steal' a bit when
addressing issues (once I got the time).

I know you'd prefer we were looser about committing if tests just
pass, but it comes down to what each committer is comfortable taking
responsibility for - and I'm not willing to generally commit larger
patches like that unless I have thoroughly vetted them - something
that takes a lot of my time.

I hope you continue contributing in any case!


Reply via email to