[ https://issues.apache.org/jira/browse/LUCENE-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504825#comment-13504825 ]
Michael McCandless commented on LUCENE-4236: -------------------------------------------- +1 This patch looks great! It cleans up BS2 and specialized term conjunction scorer, and makes more accurate decisions about which sub-scorer to enumerate first (no more first docID heuristic). We could also use the cost estimate to sometimes let BooleanScorer take MUST clauses. > clean up booleanquery conjunction optimizations a bit > ----------------------------------------------------- > > Key: LUCENE-4236 > URL: https://issues.apache.org/jira/browse/LUCENE-4236 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Robert Muir > Fix For: 4.1 > > Attachments: LUCENE-4236.patch, LUCENE-4236.patch, LUCENE-4236.patch, > LUCENE-4236.patch > > > After LUCENE-3505, I want to do a slight cleanup: > * compute the term conjunctions optimization in scorer(), so its applied even > if we have optional and prohibited clauses that dont exist in the segment > (e.g. return null) > * use the term conjunctions optimization when optional.size() == > minShouldMatch, as that means they are all mandatory, too. > * don't return booleanscorer1 when optional.size() == minShouldMatch, because > it means we have required clauses and in general BS2 should do a much better > job (e.g. use advance). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org