[
https://issues.apache.org/jira/browse/SOLR-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505201#comment-13505201
]
Yonik Seeley commented on SOLR-2052:
------------------------------------
bq. the fact that existing tests pass when you remove it doesn't in and of
itself fill me with tons of confidence that it's definitely safe.
+1
I think some of the history is that stock Solr never used both at the same
time, and because of that maybe not every place in the code worked with both,
and because of that someone added the check/restriction. I have no idea if all
code paths would worth using both, but it's not something the current tests
test for (since it's prohibited). Changes to that should be backed up by new
tests, and coverage analysis and/or a thorough code review.
> Allow for a list of filter queries and a single docset filter in
> QueryComponent
> -------------------------------------------------------------------------------
>
> Key: SOLR-2052
> URL: https://issues.apache.org/jira/browse/SOLR-2052
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0-ALPHA
> Environment: Mac OS X, Java 1.6
> Reporter: Stephen Green
> Priority: Minor
> Fix For: 4.1
>
> Attachments: SOLR-2052-2.patch, SOLR-2052-3-6-1.patch,
> SOLR-2052-3.patch, SOLR-2052-4_0_0.patch, SOLR-2052-4.patch, SOLR-2052.patch,
> SOLR-2052-trunk.patch
>
>
> SolrIndexSearcher.QueryCommand allows you to specify a list of filter queries
> or a single filter (as a DocSet), but not both. This restriction seems
> arbitrary, and there are cases where we can have both a list of filter
> queries and a DocSet generated by some other non-query process (e.g.,
> filtering documents according to IDs pulled from some other source like a
> database.)
> Fixing this requires a few small changes to SolrIndexSearcher to allow both
> of these to be set for a QueryCommand and to take both into account when
> evaluating the query. It also requires a modification to ResponseBuilder to
> allow setting the single filter at query time.
> I've run into this against 1.4, but the same holds true for the trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
