Whew, yeah - takes as long for me as it does to run the tests! I think this type of thing is better enforced by jenkins than doubling the length of my commit process.
I feel the same thing about the license stuff - sure it's nice to be able to check it ahead of time - but I'm pretty happy running ant test and letting jenkins catch the 1 out of 10 issues that are not caught right away. - Mark On Wed, Nov 28, 2012 at 5:04 PM, Robert Muir <[email protected]> wrote: > its currently a little slow unfortunately because our javadocs generation is > slow (maybe 5 minutes). but it does the checks jenkins does. > > so i do: > > ant precommit test > # get a coffee and/or beer > svn commit > > > On Wed, Nov 28, 2012 at 5:00 PM, Mark Miller <[email protected]> wrote: >> >> ant precommit is a new one to me. >> >> - Mark >> >> On Nov 28, 2012, at 4:47 PM, Michael McCandless >> <[email protected]> wrote: >> >> > Maybe you should get in the habit of running "ant precommit" before >> > committing. >> > >> > Mike McCandless >> > >> > http://blog.mikemccandless.com >> > >> > On Wed, Nov 28, 2012 at 2:57 PM, Mark Miller <[email protected]> >> > wrote: >> >> I've fixed this. >> >> >> >> On Wed, Nov 28, 2012 at 2:46 PM, Policeman Jenkins Server >> >> <[email protected]> wrote: >> >>> Build: >> >>> http://jenkins.sd-datasolutions.de/job/Lucene-Solr-trunk-Linux/2921/ >> >>> Java: 32bit/jdk1.7.0_09 -client -XX:+UseG1GC >> >>> >> >>> All tests passed >> >>> >> >>> Build Log: >> >>> [...truncated 24538 lines...] >> >>> BUILD FAILED >> >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-trunk-Linux/build.xml:296: The >> >>> following error occurred while executing this line: >> >>> >> >>> /mnt/ssd/jenkins/workspace/Lucene-Solr-trunk-Linux/extra-targets.xml:117: >> >>> The following files are missing svn:eol-style (or binary svn:mime-type): >> >>> * solr/licenses/guava-13.0.1.jar.sha1 >> >>> >> >>> Total time: 19 minutes 30 seconds >> >>> Build step 'Invoke Ant' marked build as failure >> >>> Archiving artifacts >> >>> Recording test results >> >>> Description set: Java: 32bit/jdk1.7.0_09 -client -XX:+UseG1GC >> >>> Email was triggered for: Failure >> >>> Sending email for trigger: Failure >> >>> >> >>> >> >>> >> >>> >> >>> --------------------------------------------------------------------- >> >>> To unsubscribe, e-mail: [email protected] >> >>> For additional commands, e-mail: [email protected] >> >> >> >> >> >> >> >> -- >> >> - Mark >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: [email protected] >> >> For additional commands, e-mail: [email protected] >> >> >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] >> > For additional commands, e-mail: [email protected] >> > >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > -- - Mark --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
