On Fri, Nov 30, 2012 at 1:08 PM, Shai Erera <ser...@gmail.com> wrote: >> Hmm prepareCommit() really should somehow pass true: this API is only >> invoked by the app, not by IW internally during close. > > > Currently, the app can call prepareCommit() or prepareCommint(data), the > former calls ensureOpen(true), the latter ensureOpen(false). > > The problem is that the latter is called by internalCommit(). So when I > changed prepareCommit(data) to call ensureOpen(true), all TestIndexWriter > tests failed (the only ones I tried).
OK I see. > So I think that in that issue, I should create an internalPrepareCommit and > leave prepCommit() to call ensureOpen(), while internalPrep will call > ensureOpen(false). And also change IW code to call internalCommit. How's > that sound? That sounds good! Thanks. Mike McCandless http://blog.mikemccandless.com --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
