[
https://issues.apache.org/jira/browse/SOLR-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507613#comment-13507613
]
Shawn Heisey commented on SOLR-3918:
------------------------------------
Discussion on SOLR-4129 touched on this issue. I think my patch for this issue
needs to be committed. My patch does two things: 1) adds a new target so you
can exclude slf4j but still get everything else that "dist" gives you now. 2)
Removes the sl4j api jar from the war in addition to the other slf4j jars.
Restating my reasoning for number 2:
When you choose to exclude slf4j and use your own binding, you're already going
to have to go track down jars from an external source and add them to your
install. The path of least resistance will lead you to download a newer
version of slf4j (1.7.2 right now) than is found in Solr (1.6.4 right now).
Because of the api jar sitting in the war, this won't work. If a bug or
performance problem is found that affects Solr, it's a fair amount of manual
work to get operational with a new slf4j version. My patch eliminates that
problem, with the additional requirement that you include the api jar yourself.
> Change the way -excl-slf4j targets work
> ---------------------------------------
>
> Key: SOLR-3918
> URL: https://issues.apache.org/jira/browse/SOLR-3918
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 3.6.1, 4.0-BETA
> Reporter: Shawn Heisey
> Priority: Trivial
> Fix For: 3.6.2, 4.1, 5.0
>
> Attachments: SOLR-3918.patch, SOLR-3918.patch
>
>
> If you want to create an entire dist target but leave out slf4j bindings, you
> must currently use this:
> ant dist-solrj, dist-core, dist-test-framework, dist-contrib
> dist-war-excl-slf4j
> It would be better to have a single target. Attaching a patch against
> branch_4x for this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
