[
https://issues.apache.org/jira/browse/LUCENE-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508181#comment-13508181
]
Shai Erera commented on LUCENE-4580:
------------------------------------
I took a look at TermsFilter (under the queries module), and I think that it
would be a waste to write another version for facets. However, DrillDown is
only a helper class and I'm not sure that it's worth adding lucene-queries as a
dependency, especially that we have LUCENE-3998 open for removing dependencies
from it :).
So I wonder if instead we should have only a Term / List<Term> helper methods
and document that the caller can use TermsFilter? E.g.:
{code}
Filter facets = new TermsFilter(DrillDown.terms(CategoryPath...));
{code}
Really, this is a very simple code. What do you think?
> Facet DrillDown should return a Filter not Query
> ------------------------------------------------
>
> Key: LUCENE-4580
> URL: https://issues.apache.org/jira/browse/LUCENE-4580
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Shai Erera
> Priority: Minor
>
> DrillDown is a helper class which the user can use to convert a facet value
> that a user selected into a Query for performing drill-down or narrowing the
> results. The API has several static methods that create e.g. a Term or Query.
> Rather than creating a Query, it would make more sense to create a Filter I
> think. In most cases, the clicked facets should not affect the scoring of
> documents. Anyway, even if it turns out that it must return a Query (which I
> doubt), we should at least modify the impl to return a ConstantScoreQuery.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
