[ 
https://issues.apache.org/jira/browse/SOLR-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510132#comment-13510132
 ] 

Mark Miller commented on SOLR-3428:
-----------------------------------

This can likely be closed - at some point I fixed 1 and 2 (adding Per to the 
CHANGES entries) and added targeted tests for them and I'm not yet convinced 
that 3 is a problem (which doesn't guarantee it's not - but I have not found a 
situation where it is a problem).
                
> SolrCmdDistributor flushAdds/flushDeletes problems
> --------------------------------------------------
>
>                 Key: SOLR-3428
>                 URL: https://issues.apache.org/jira/browse/SOLR-3428
>             Project: Solr
>          Issue Type: Bug
>          Components: replication (java), SolrCloud, update
>    Affects Versions: 4.0-ALPHA
>            Reporter: Per Steffensen
>            Assignee: Per Steffensen
>              Labels: add, delete, replica, solrcloud, update
>             Fix For: 4.1
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> A few problems with SolrCmdDistributor.flushAdds/flushDeletes
> * If number of AddRequests/DeleteRequests in alist/dlist is below limit for a 
> specific node the method returns immediately and doesnt flush for subsequent 
> nodes
> * When returning immediately because there is below limit requests for a 
> given node, then previous nodes that have already been flushed/submitted are 
> not removed from adds/deletes maps (causing them to be flushed/submitted 
> again the next time flushAdds/flushDeletes is executed)
> * The idea about just combining params does not work for SEEN_LEADER params 
> (and probably others as well). Since SEEN_LEADER cannot be expressed (unlike 
> commitWithin and overwrite) for individual operations in the request, you 
> need to sent two separate submits. One containing requests with 
> SEEN_LEADER=true and one with SEEN_LEADER=false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to