[ 
https://issues.apache.org/jira/browse/LUCENE-4585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510535#comment-13510535
 ] 

David Smiley commented on LUCENE-4585:
--------------------------------------

I'll commit this tomorrow if there are no objections.

For those of you that didn't look at the patch, note that it adds an entry up 
in the API compatibility section:
{quote}
* LUCENE-4585: Spatial PrefixTree based Strategies (either TermQuery or
  RecursivePrefix based) MAY want to re-index if used for point data. If a
  re-index is not done, then an indexed point is ~1/2 the smallest grid cell
  larger and as such is slightly more likely to match a query shape.
  (David Smiley)
{quote}
Strictly speaking this is not an API change but there wasn't a upgrade section. 
 This note I added is also quite minor (in fact the behavior of a point 
matching its entire grid cell might be desirable) so arguably I could simply 
not mention it; but I'm err'ing on the side of full disclosure.
                
> Spatial RecursivePrefixTreeFilter has some bugs with indexing non-point shapes
> ------------------------------------------------------------------------------
>
>                 Key: LUCENE-4585
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4585
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial
>    Affects Versions: 4.0
>            Reporter: David Smiley
>            Assignee: David Smiley
>         Attachments: LUCENE-4585_PrefixTree_bugs.patch, 
> LUCENE-4585_PrefixTree_bugs.patch
>
>
> RecursivePrefixTreeFilter has some bugs that can occur when searching indexed 
> shapes.  One bug is an unpositioned termsEnum.  It through an exception in 
> testing; I'm not sure what its effects would be in production.  The other 
> couple bugs are hard to describe here but were rare to occur in extensive 
> testing. The effects were probably a slim chance of matching an indexed shape 
> near the query shape. And SpatialPrefixTree does not support an indexed shape 
> that covers the entire globe.
> These bugs were discovered during development of tests for RPTF LUCENE-4419 
> which I will submit shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to