[
https://issues.apache.org/jira/browse/LUCENE-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511244#comment-13511244
]
Shai Erera commented on LUCENE-4588:
------------------------------------
Patch looks good ! Nice catch. Few minor (styling) comments, feel free to
ignore:
* In EnwikiCSTest.Stringable, I would make docs 'final'.
* I would change assertNoMoreDataException like this:
{code}
private void assertNoMoreDataException(EnwikiContentSource stdm) throws
Exception {
try {
stdm.getNextDocData(null);
fail("Expecting NoMoreDataException");
} catch (NoMoreDataException e) {
// expected
}
}
{code}
> EnwikiContentSource silently swallows the last wiki doc
> -------------------------------------------------------
>
> Key: LUCENE-4588
> URL: https://issues.apache.org/jira/browse/LUCENE-4588
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/benchmark
> Reporter: Doron Cohen
> Assignee: Doron Cohen
> Priority: Minor
> Attachments: LUCENE-4588.patch
>
>
> Last wiki doc is never returned
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
