[
https://issues.apache.org/jira/browse/LUCENE-4593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511479#comment-13511479
]
Robert Muir commented on LUCENE-4593:
-------------------------------------
I actually noticed the spike stuff in finish() too.
because thats where we currently take the whole grow()'ed byte[] used during
construction and shrink it to the actual necessary size we need.
We are doing this anyway, so we could just use something else for intermediate
buffering instead.
One confusing thing is that FST is like an immutable concept from the outside,
but from the code on the inside its mutable.
I really wish the buffering and stuff was instead encapsulated in Builder or
somewhere else so that FST was simpler and immutable.
> clean up FST storage abstractions
> ---------------------------------
>
> Key: LUCENE-4593
> URL: https://issues.apache.org/jira/browse/LUCENE-4593
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-4593.patch
>
>
> I was looking at James patch for LUCENE-3298, and I thought that you know,
> FST *almost* abstracts its underlying "i/o" (storage) via reader/writer
> abstractions.
> It would be good to try to work on this more, e.g. we can imagine a little
> abstraction like lucene has a Store (Directory).
> This way maybe we could cleanup the packed vs non-packed, allow for > 2GB
> fsts without slowing down small ones, and so on.
> I have a patch that is like an amoeba-step towards this
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
