[ https://issues.apache.org/jira/browse/LUCENE-4615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528751#comment-13528751 ]
Shai Erera commented on LUCENE-4615: ------------------------------------ Took a look in the code, the allocators are used mostly by FacetArrays, so perhaps that can be the abstraction level? I.e. we make FacetArrays expose API similar to acquire/release of int[]/float[]. The default impl would always allocate new, and discard in release. A ReusingFacetArrays would use the current allocators logic? > Remove Int/FloatArrayAllocator from facet module? > ------------------------------------------------- > > Key: LUCENE-4615 > URL: https://issues.apache.org/jira/browse/LUCENE-4615 > Project: Lucene - Core > Issue Type: Bug > Reporter: Michael McCandless > > Spinoff from LUCENE-4600. > It makes me nervous to have allocation tied to our public APIs ... and the > ability for Int/FloatArrayAllocator to hold onto N arrays indefinitely makes > me even more nervous. I think we should just trust java/GC to do their job > here and free the storage as soon as faceting is done. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org