[ 
https://issues.apache.org/jira/browse/SOLR-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man updated SOLR-3918:
---------------------------

    Attachment: SOLR-3918.patch


I don't personally see the need for dist-excl-slf4j (is it so terrible to use 
"ant dist dist-war-excl-slf4j" and ignore the regular war?) but i don't object 
to it.

I do however object to having "dist-common" be an advertised target -- if it's 
not something we want people to ever run from the command line, it shouldn't 
show up in "ant -p" (we're trying to make that list smaller, not bigger)

The attached patch fixes this, as well as fixes the other descriptions to be 
clear that now it excludes _everything_ rleated to SLF4J.

Shawn: if this looks good to you, and if you edit 
https://wiki.apache.org/solr/SolrLogging with instructions on how to use it, 
i'll happily commit it.

(and if i forget, or don't notice you added the instructions to the wiki: send 
me an email every hour until i do)
                
> Change the way -excl-slf4j targets work
> ---------------------------------------
>
>                 Key: SOLR-3918
>                 URL: https://issues.apache.org/jira/browse/SOLR-3918
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 3.6.1, 4.0-BETA
>            Reporter: Shawn Heisey
>            Priority: Trivial
>             Fix For: 3.6.2, 4.1, 5.0
>
>         Attachments: SOLR-3918.patch, SOLR-3918.patch, SOLR-3918.patch
>
>
> If you want to create an entire dist target but leave out slf4j bindings, you 
> must currently use this:
> ant dist-solrj, dist-core, dist-test-framework, dist-contrib 
> dist-war-excl-slf4j
> It would be better to have a single target.  Attaching a patch against 
> branch_4x for this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to