Thanks Uwe: I really mean it. I'll back out this change and we can figure out a way to prevent false failures of this JVM. I would really prefer if this was some other way, *not* a compilation exclusion of the pack() method, as I am actively trying to refactor FST packing: https://issues.apache.org/jira/browse/LUCENE-4593
On Fri, Dec 14, 2012 at 7:31 AM, <uschind...@apache.org> wrote: > Author: uschindler > Date: Fri Dec 14 12:31:05 2012 > New Revision: 1421818 > > URL: http://svn.apache.org/viewvc?rev=1421818&view=rev > Log: > Revert the revert of the revert. I hope Robert Muir will followup and we can > agree that this patch is not really a good idea and we should discuss on > LUCENE-4630 what to do. I know that Mike is already beasting J9, so we would > need an option to disable this AssumptionFailedEx. Thanks in advance! > > Modified: > > lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleSetupAndRestoreClassEnv.java > > Modified: > lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleSetupAndRestoreClassEnv.java > URL: > http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleSetupAndRestoreClassEnv.java?rev=1421818&r1=1421817&r2=1421818&view=diff > ============================================================================== > --- > lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleSetupAndRestoreClassEnv.java > (original) > +++ > lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleSetupAndRestoreClassEnv.java > Fri Dec 14 12:31:05 2012 > @@ -200,6 +200,9 @@ final class TestRuleSetupAndRestoreClass > Arrays.toString(avoidCodecs.toArray())); > throw e; > } > + if (Constants.JAVA_VENDOR.startsWith("IBM")) { > + throw new AssumptionViolatedException("refusing to execute on broken > jvm"); > + } > } > > /** > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
