[ 
https://issues.apache.org/jira/browse/SOLR-4136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man resolved SOLR-4136.
----------------------------

    Resolution: Fixed

Hmmm, mark: i tried testing on both trunk@1422017 and 4x@1422022...

 * that seed did in fact produce the root context "/" for me
 * that tests passed with that seed and the root context
 * no where in the test log did get any mention of "//unloadcollection2" (which 
i would suspect if there was a bug building up a client url using the 
baseUrlWithTrailingSlash + "/corename" ... but there should never be a 
baseUrlWithTrailingSlash)

I then modified my local working copy of trunk like so, in order to force every 
test to run with the root context, and even then i could not reproduce...

{noformat}
Index: 
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
===================================================================
--- 
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java 
    (revision 1422017)
+++ 
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java 
    (working copy)
@@ -110,7 +110,9 @@
       }
     }
     // paranoia, we *really* don't want to ever get "//" in a path...
-    final String hc = hostContext.toString().replaceAll("\\/+","/");
+    // final String hc = hostContext.toString().replaceAll("\\/+","/");
+    // :nocommit: ... test the shit out of the root context
+    final String hc = "/";
 
     log.info("Setting hostContext system property: " + hc);
     System.setProperty("hostContext", hc);
{noformat}

...this smells to me like it must have run against the code prior to my 
r1421034 commit (to get that "//" URL)
                
> SolrCloud bugs when servlet context contains "/" or "_"
> -------------------------------------------------------
>
>                 Key: SOLR-4136
>                 URL: https://issues.apache.org/jira/browse/SOLR-4136
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: 4.0
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>             Fix For: 4.1, 5.0
>
>         Attachments: SOLR-4136.patch, SOLR-4136.patch, SOLR-4136.patch, 
> SOLR-4136.patch, SOLR-4136.patch
>
>
> SolrCloud does not work properly with non-trivial values for "hostContext" 
> (ie: the servlet context path).  In particular...
> * Using a hostContext containing a  "/" (ie: a servlet context with a subdir 
> path, semi-common among people who organize webapps hierarchically for lod 
> blanacer rules) is explicitly forbidden in ZkController because of how the 
> hostContext is used to build a ZK nodeName
> * Using a hostContext containing a "\_" causes problems in 
> OverseerCollectionProcessor where it assumes all "\_" characters should be 
> converted to "/" to reconstitute a URL from nodeName (NOTE: this code 
> specifically has a TODO to fix this, and then has a subsequent TODO about 
> assuming "http://"; labeled "this sucks")

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to