[ 
https://issues.apache.org/jira/browse/LUCENE-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532578#comment-13532578
 ] 

Dawid Weiss commented on LUCENE-4630:
-------------------------------------

bq. but if you set "-Dtest.suspicious.shit=true" then instead the runner will 
run those tests anyway, 

This you can do already; test groups can be turned on and off by overriding 
their assigned system property, no problem with that.

bq. but wrap any failures/exceptions it gets in another 
"FailureUnderSuspiciousCircumstances" exception whose getMessage() would 
contain info about what assumption would have normally prevented that test from 
if you hadn't gone out of your way to run it.

Even this description makes me feel dizzy... :) I get your idea but I don't 
know how to implement it in a sensible way. It _could_ be a rule that would 
intercept failures, check for groups annotations and then rethrow... but I 
honestly don't think many people would find it useful (or understand the 
principle under which it operates).

Dawid
                
> add a system property to allow testing of suspicious stuff
> ----------------------------------------------------------
>
>                 Key: LUCENE-4630
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4630
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Priority: Blocker
>             Fix For: 4.1
>
>
> there are times when people want to add assumptions in test to prevent 
> confusing/false failures in certain situations (eg: known bugs in JVM X, 
> known incompatibilities between lucene feature Z and filesystem Y, etc...)
> By default we want these situations to be "skiped" in tests with clear 
> messages so that it's clear to end users trying out releases that these tests 
> can't be run for specific sitautions.
> But at the same time we need a way for developers to be able to try running 
> these tests anyway so we know if/when the underliyng problem is resolved.
> i propose we add a "tests.suspicious.shit" system property, which defaults to 
> "false" in the javacode, but can be set at runtime to "true"
> assumptions about things like incompatibilities with OSs, JVM vendors, JVM 
> versions, filesystems, etc.. can all be dependent on this system propery.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to