[
https://issues.apache.org/jira/browse/SOLR-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532972#comment-13532972
]
Uwe Schindler commented on SOLR-4195:
-------------------------------------
Hi Hoss:
Unfortunately I was not able to attend the IRC discussion completely; I just
followed it later, but the approsach with chmod will fail horribly with Windows
and is not really needed and makes it more complex (you mention ant clean is
complicated).
We have the test-infrastructure already "enforcing" this thing - but by copying
the test-files to the module's build directory we explicitely allow them to be
read/write.
If you want them read-only, you don't need to copy them to build directory,
just leave them where they are. The test framework installs a security manager
in Java that disallows writes outside the module's build directory completely.
When the test tries to write a file outside build dir, it will fail, very easy.
If you have time, we should discuss this one more time here, before committing
this patch :-) So my -1 to this solution.
> chmod a-x build/**/test-files when running tests
> ------------------------------------------------
>
> Key: SOLR-4195
> URL: https://issues.apache.org/jira/browse/SOLR-4195
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-4195.patch
>
>
> Until recently, I thought the solr test framework was setup such that every
> test got it's own copy of the "test-files/solr" directory to use as it's Solr
> Home Dir -- then mark committed r1421543, to fix a problem where that test
> was writing a file (that would later be removed) to the solr conf dir, which
> would confuse another currently running test and cause it to fail.
> This made me realize that what i was remembering is that the ant build files
> copy the src/test-files directories into build/ prior to running the tests --
> but all tests (in that module) still share the same copy.
> Subsequent discussions with folks on IRC lead me to the following
> realizations..
> * making a copy of the test-files dir for each test would help eliminate
> confusing by reducing non-reproducible failures if tests collide -- but might
> be slow
> * making a copy of the test-files dir for each test would not help identify
> situations were code was mistakenly/unexpectedly writing to the solr home dir
> * what would probably make the most sense, would be to make the
> build/test-files directory "read only". that way by default tests would get
> a read only solr home dir -- triggering failures if the code is broken and
> tries to write to that dir. tests that want/need to write to the solr home
> dir would have to go out of their way to clone the read only test-files/solr
> directory and use it as their solr home.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
