[ https://issues.apache.org/jira/browse/SOLR-4086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536089#comment-13536089 ]
Dominik Siebel commented on SOLR-4086: -------------------------------------- [~jdyer] I noticed a massive decrease in indexing performance when trying a current checkout from branch_4x after this refactoring. Do you have any explanation for that? Looking through the code I could not find any changes that would explain this. *Some numbers:* * 1.3M documents * 4 DIHs *before* (with my patch from SOLR-2141): * DIH_1: documents processed: 325130, time taken: 00:25:44.445 * DIH_2: documents processed: 207347, time taken: 01:16:04.607 * DIH_3: documents processed: 184601, time taken: 01:18:00.797 * DIH_4: documents processed: 618580, time taken: 04:17:38.414 *after*: * DIH_1: documents processed: 324996, time taken: 01:07:47.186 * DIH_2: documents processed: 207347, time taken: 03:31:21.345 * DIH_3: documents processed: 184521, time taken: 03:13:11.313 * DIH_4: documents processed: 618491, time taken: 06:42:54.384 Any idea? > Refactor DIH - VariableResolver & Evaluator > ------------------------------------------- > > Key: SOLR-4086 > URL: https://issues.apache.org/jira/browse/SOLR-4086 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler > Affects Versions: 4.0 > Reporter: James Dyer > Assignee: James Dyer > Priority: Minor > Fix For: 4.1, 5.0 > > Attachments: SOLR-4086.patch > > > This simplifies VariableResolver and moves each built-in Evaluator into its > own class. Compiler warnings / missing generics are fixed. Also, the Locale > bug with DateFormatEvaluator is solved. Instead of using the machine > default, the Root Locale is used by default. An optional 3rd parameter > allows users to specify whatever locale they want. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org