[ 
https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536651#comment-13536651
 ] 

Mark Miller commented on SOLR-4196:
-----------------------------------

Yeah, but since the xml is not very complex, most of it just seemed like grunt 
work, and perhaps not too much of it? I have not looked too closely in a while, 
but I would have approached it by just making a 'solr.xml' java object that I 
stuck the settings on and then pass it around same as the xml dom was passed 
around. Its just replacing one value holder for another right?

bootstrapConf for example, just wants to get a couple of the properties off the 
cores. This is probably going to be a common thing - getting both corecontainer 
and core level properties...that is what solr.xml is all about.

So like in the persist code I would make a class to represent a cores 
properties and then I'd make a class to represent the corecontainers 
properties. Then I'd compose these classes based on teh dir layout and configs 
and sys properties and end up with a core container object with n properties 
and y core objects with x properties. boostrapConf would get to easily pull the 
core properties it wants, and so would every other place that ends up needing 
to look at a cores properties. CoreContainer level properties would also be 
available to pass around.
                
> Untangle XML-specific nature of Config and Container classes
> ------------------------------------------------------------
>
>                 Key: SOLR-4196
>                 URL: https://issues.apache.org/jira/browse/SOLR-4196
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 4.1, 5.0
>
>
> sub-task for SOLR-4083. If we're going to try to obsolete solr.xml, we need 
> to pull all of the specific XML processing out of Config and Container. 
> Currently, we refer to xpaths all over the place. This JIRA is about 
> providing a thunking layer to isolate the XML-esque nature of solr.xml and 
> allow a simple properties file to be used instead which will lead, 
> eventually, to solr.xml going away.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to