[ 
https://issues.apache.org/jira/browse/LUCENE-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539038#comment-13539038
 ] 

Mark Miller edited comment on LUCENE-4246 at 12/23/12 3:09 PM:
---------------------------------------------------------------

Why don't the docs say that then? I'm not even confident that will work.

But look at the docs - it's telling you to keep calling close, its trying to 
get you to force unlock in a finally - it doesnt even mention rollback.

And are you sure rollback will not be interrupted either? Rollback throws 
IOException and you are not dealing with it. If it's really that simple, why 
has the javadocs evolved into a mess of bad recommendations and information?

And if that is the proper way, why doesnt writer.close do that for the user and 
then throw an exception?

These are crazy semantics.
                
      was (Author: [email protected]):
    Why don't the docs say that then? I'm not even confident that will work.

But look at the docs - it's telling you to keep calling close, its trying you 
to force unlock in a finally - it doesnt even mention rollback.

And are you sure rollback will not be interrupted either? Rollback throws 
IOException and you are not dealing with it. If it's really that simple, why 
has the javadocs evolved into a mess of bad recommendations and information?

And if that is the proper way, why doesnt writer.close do that for the user and 
then throw an exception?

These are crazy semantics.
                  
> Fix IndexWriter.close() to not commit or wait for pending merges
> ----------------------------------------------------------------
>
>                 Key: LUCENE-4246
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4246
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 4.1
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to