[
https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-4196:
---------------------------------
Attachment: SOLR-4196.patch
OK, here's a patch. It has lots of stuff left to do, I'm just putting it up for
your delectation. And anyone who wants to jump in and help, please feel free....
But it's a lot of code changes, I'm amazed that it works as well as it does.
There are lots of TODOs. Nobody should even think about committing this. What
it does is separate out all of the XML-specific code from CoreContainer (and a
couple of other classes) and provide a thunking class. The thunking class
doesn't yet implement doing anything with a properties file, it just sends
calls to the old Config class.
It also moves a bunch of stuff to the old Config class that may not really
belong there since they're specific to solr.xml not general xml config classes.
It seems like it'd be cleaner to create a new class to hold the stuff specific
to solr.xml, then we'd have a SolrProperties and SolrOldXml class or some such.
But I'll leave that for a bit later, want to get this stuff up into the JIRA
for people to take a look at for the general approach, we can deal with ugly
details before it's finally committed.
I'm fairly pleased that only a few tests are failing:
BasicDistributedZkTest
ZkCLITest
I'll probably be able to take a look at these later this holiday, but I just
managed to fix up 208 _other_ failing cases (alright, it only took one code
change, but still <G>).
> Untangle XML-specific nature of Config and Container classes
> ------------------------------------------------------------
>
> Key: SOLR-4196
> URL: https://issues.apache.org/jira/browse/SOLR-4196
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4196.patch
>
>
> sub-task for SOLR-4083. If we're going to try to obsolete solr.xml, we need
> to pull all of the specific XML processing out of Config and Container.
> Currently, we refer to xpaths all over the place. This JIRA is about
> providing a thunking layer to isolate the XML-esque nature of solr.xml and
> allow a simple properties file to be used instead which will lead,
> eventually, to solr.xml going away.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
