[
https://issues.apache.org/jira/browse/LUCENE-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540590#comment-13540590
]
David Smiley commented on LUCENE-4616:
--------------------------------------
FYI Solr's AbstractSpatialFieldType#getQueryFromSpatialArgs() has this excerpt:
{code:java}
String score = (localParams == null ? null : localParams.get(SCORE_PARAM));
if (score == null || "none".equals(score) || "".equals(score)) {
//FYI Solr FieldType doesn't have a getFilter(). We'll always grab
// getQuery() but it's possible a strategy has a more efficient getFilter
// that could be wrapped -- no way to know.
//See SOLR-2883 needScore
return strategy.makeQuery(spatialArgs); //ConstantScoreQuery
}
{code}
With the change that Ryan proposes in this issue, that
SpatialStrategy#makeQuery can return a scoring query if it chooses, this code
should no longer return makeQuery(), it should wrap makeFilter() in a
ConstantScoreQuery. Not a big deal but I just want to make note of it as it
affects this issue.
> Clarify what the score means in SpatialStrategy#makeQuery()
> -----------------------------------------------------------
>
> Key: LUCENE-4616
> URL: https://issues.apache.org/jira/browse/LUCENE-4616
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: Ryan McKinley
> Priority: Trivial
>
> SpatialStrategy#makeQuery() returns a Query, but the docs don't make it clear
> with the score value should be.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
