[ 
https://issues.apache.org/jira/browse/SOLR-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540987#comment-13540987
 ] 

Shawn Heisey commented on SOLR-656:
-----------------------------------

Patch is not working.  Running all tests on trunk (linux) results in a number 
of failures that probably *are* caused by this patch.  Running all tests on 
branch_4x (windows) results in failures, one of which is actually my new test - 
which passed earlier.

When my new test failed, it was complaining about thread leaks.  My test 
approach probably needs some work, but I'm not familiar enough with the test 
frameworks.  I suspect that what needs to happen is that I need to lock the 
index directory to a known location, then make that directory and do initCore.  
Optionally, I could instead initCore in a the specific directory, destroy the 
core completely, delete all the index files, and attempt to initCore again in 
the same directory.  I do not know how to go about doing this.

                
> better error message when "data/index" is completely empty
> ----------------------------------------------------------
>
>                 Key: SOLR-656
>                 URL: https://issues.apache.org/jira/browse/SOLR-656
>             Project: Solr
>          Issue Type: Wish
>            Reporter: Hoss Man
>             Fix For: 4.2, 5.0
>
>         Attachments: SOLR-656.patch
>
>
> Solr's normal behavior is to create an "index" dire in the dataDir if one 
> does not already exist, but if "index" does exist it is used as is, warts and 
> all ... if the index is corrupt in some way, and Solr can't create an 
> IndexWriter or IndexReader that error is propagated up to the user.
> I don't think this should change: Solr shouldn't attempt to do anything 
> special if there is a low level problem with the index, but something that 
> i've seen happen more then a few times is that people unwittingly "rm 
> index/*" when they should "run -r index" and as a result Solr+Lucene gives 
> them an error instead of just giving them an empty index
> when checking if an existing index dir exists, it would probably be worth 
> while to add a little one line sanity test that it contains some files, and 
> log a warning.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to