Mostly checking to see if I'm understanding things correctly. If system properties are supposed to override properties file settings, then this method seems wrong, the putAll will make anything set in the properties file be what's specified as a system property.
My guess is that this logic is a little twisted and solrcore.properties files are supposed to override system properties, so it's actually correct, I don't really see how this would work otherwise, a system property setting, for instance, instanceDir would then override _all_ individually-set instanceDirs so that just seems wrong...... Thanks, Erick
