[ https://issues.apache.org/jira/browse/LUCENE-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542168#comment-13542168 ]
Robert Muir commented on LUCENE-4649: ------------------------------------- Really as part of this issue we should re-enable mmap/niofs for TestIndexWriter.testThreadInterruptDeadlock() ? Its like if we havent fixed that case (LUCENE-4638), then we havent fixed this issue correctly... > kill ThreadInterruptedException > ------------------------------- > > Key: LUCENE-4649 > URL: https://issues.apache.org/jira/browse/LUCENE-4649 > Project: Lucene - Core > Issue Type: Bug > Reporter: Robert Muir > Attachments: LUCENE-4649_broken.patch > > > the way we currently do this is bogus. > For example in FSDirectory's fsync, i think we should instead: > {noformat} > } catch (InterruptedException ie) { > - throw new ThreadInterruptedException(ie); > + Thread.currentThread().interrupt(); // restore status > + IOException e = new java.io.InterruptedIOException("fsync() interrupted"); > + e.initCause(ie); > + throw e; > {noformat} > and crazy code in IndexWriter etc that catches ThreadInterruptedExc just to > restore status should be removed. > Instead the guy doing the catch (InterruptedException) should do the right > thing. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org