[ 
https://issues.apache.org/jira/browse/SOLR-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated SOLR-4265:
--------------------------------

    Attachment: SOLR-4265.patch

Patch:
- adds several ServletRequest and ServletResponse methods to forbidden apis 
(getReader/getWriter/getParameter as those are unsafe with charsets)
- Uses SolrRequestParsers to parse URL parameters and also form-encoded POST 
according to the standards. It also support form-encoded post data with 
different charsets than UTF-8 (but this charset is then also used for 
eventually given URL parameters)
- Fixes the ZookeeperInfoServlet, too (not use unsafe Readers, Writers, 
getParameter)
- The DebugServlet in the SolrJ tests is exclued from forbidden API

All tests pass. I will do more tests with other servlet containers (Tomcat) and 
see if Solr works with UTF without any modifications.
                
> Encoding problem from test console
> ----------------------------------
>
>                 Key: SOLR-4265
>                 URL: https://issues.apache.org/jira/browse/SOLR-4265
>             Project: Solr
>          Issue Type: Bug
>          Components: web gui
>    Affects Versions: 4.0
>         Environment: Windows but, environment independent
>            Reporter: Alex Rocher
>            Priority: Blocker
>         Attachments: SOLR-4265.patch, SolrDispatchFilter.java.patch
>
>
> When you type an accent (in french language for example) in the console query 
> tester, there's no charset conversion (servlet request charset conversion)
> Eg.: "même" is converted into it's ISO-8859-1 representation ==> fail
> The reason : getCharacterEncoding from HTTPRequest is not tested. Il it's 
> null, il will assume to convert an UTF-8 encoding charset.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to