[
https://issues.apache.org/jira/browse/SOLR-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated SOLR-4226:
------------------------------
Attachment: SOLR-4226.patch
Thanks Ryan: here's an updated patch. I added javadocs (since its a new
abstract class).
Also i just made all the members abstract: having some of the concrete stuff
might be confusing to subclasses and cause strange things to happen (e.g. if
they forget to set _wantsAllFields but returned null from getLuceneFieldNames).
So I think this is less error-prone.
> Extract fl parsing code out of ReturnFields constructor
> -------------------------------------------------------
>
> Key: SOLR-4226
> URL: https://issues.apache.org/jira/browse/SOLR-4226
> Project: Solr
> Issue Type: Improvement
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Ryan Ernst
> Assignee: Robert Muir
> Priority: Minor
> Attachments: SOLR-4226.patch, SOLR-4226.patch
>
>
> I would like to have my own QueryComponent, and have a more limited syntax
> for return fields. Unfortunately the ReturnFields constructor currently does
> parsing.
> If we extract the parsing code into a static method of ReturnFields, then the
> class can be a simple container, and I can have my alternate parsing code to
> fill it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
