[ 
https://issues.apache.org/jira/browse/LUCENE-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546043#comment-13546043
 ] 

Robert Muir commented on LUCENE-4643:
-------------------------------------

Well i guess my main concern is to double minValue for the "normal" cases just 
because of the silliness in termvectors.
Isn't the rest of packedints really geared at positives too?

Does things like facets need (LUCENE-4609) need negative values?
And we know the postings doesnt (it would be nice but i guess not necessary if 
we refactored blockPF's encoding here).

I guess i feel like its good enough to mark in a termvectors block as a bit if 
any of the values are negative, in which case its used zig-zag on top.

I dont understand why we should really optimize of the case of vectors where 
you have all values between -1 and 6, because
really it means you have a broken analyzer: it likely wont highlight correctly 
and so on anyway.
                
> PackedInts: convenience classes to write blocks of packed ints
> --------------------------------------------------------------
>
>                 Key: LUCENE-4643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4643
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-4643.patch, LUCENE-4643.patch
>
>
> It is often useful to divide a packed stream into fixed blocks which are all 
> compressed independently:
>  * if your sequence of ints is very large, you won't have to buffer 
> everything into memory to compute the required number of bits per value,
>  * the compression ratio will be better in case of rare extreme values.
> The only drawback compared to the original PackedInts API is that the stream 
> cannot be directly used to deserialize a random-access PackedInts.Reader (but 
> for sequential access, this is just fine).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to