[
https://issues.apache.org/jira/browse/LUCENE-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548518#comment-13548518
]
Uwe Schindler commented on LUCENE-4667:
---------------------------------------
Maybe that's the case! Sorry. I was expecting that constructors are singletons
like classes. HashMap is fine then.
In my opinion, I think maybe the whole Predicate approach is too much detailed?
I would just match on the constructor itsself and would disallow it completeley
(without looking into actual parameters). Just exclude the constructor in the
beforeClass() method when populating the lists.
If you want to keep the predicate approach, i would exclude all broken
construcors with the ALWAYS predicate in beforeClass(), so it never tries to
use the constructor at all (because its no longer in the list).
> Change TestRandomChains to replace the list of broken classes by a list of
> broken constructors
> ----------------------------------------------------------------------------------------------
>
> Key: LUCENE-4667
> URL: https://issues.apache.org/jira/browse/LUCENE-4667
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-4667.patch, LUCENE-4667.patch
>
>
> Some classes are currently in the list of bad apples although only one
> constructor is broken. For example, LimitTokenCountFilter has an option to
> consume the whole stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
