[ 
https://issues.apache.org/jira/browse/LUCENE-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrien Grand updated LUCENE-4667:
---------------------------------

    Attachment: LUCENE-4667.patch

bq. Maybe that's the case! Sorry. I was expecting that constructors are 
singletons like classes.

No problem, I had the same expectation and was a little disappointed to see 
that it didn't work!

bq. I think maybe the whole Predicate approach is too much detailed?

I think it's worth exluding with a predicate: for example this allows to test 
random chains with LimitTokenCountFilter(consumeAllTokens=true) (when 
consumeAllTokens=false, this filter is broken).

bq. I would exclude all broken construcors with the ALWAYS predicate in 
beforeClass()

Sounds good, I updated the patch.
                
> Change TestRandomChains to replace the list of broken classes by a list of 
> broken constructors
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4667
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4667
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-4667.patch, LUCENE-4667.patch, LUCENE-4667.patch
>
>
> Some classes are currently in the list of bad apples although only one 
> constructor is broken. For example, LimitTokenCountFilter has an option to 
> consume the whole stream.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to