Hey Guys
While working on SOLR-4151 (DIH 'debug' mode missing from 4.x UI) i skimmed
through the code and found this one:
129 | if (DataImporter.SHOW_CONF_CMD.equals(command)) {
130 | String dataConfigFile = params.get("config");
131 | String dataConfig = params.get("dataConfig");
132 | if(dataConfigFile != null) {
133 | dataConfig =
SolrWriter.getResourceAsString(req.getCore().getResourceLoader().openResource(dataConfigFile));
134 | }
135 | if(dataConfig==null) {
136 | rsp.add("status", DataImporter.MSG.NO_CONFIG_FOUND);
137 | } else {
138 | // Modify incoming request params to add wt=raw
from
http://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DataImportHandler.java?view=markup
What it *should* do, related to the Description of the Issue (SOLR-2115), is:
accept a temporary Config (provided by a Request-Parameter) and use it instead
of the defined one .. but, as fair as i understand the code: any provided
Config will get overwritten if there is a ConfigFile defined in your solrconfig.
There is no check in place, that this fallback should only happen if there was
no (temporary) configuration given .. or am i missing something really
important but maybe not completely obvious here?
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
