[ 
https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553622#comment-13553622
 ] 

Tomás Fernández Löbbe commented on SOLR-3039:
---------------------------------------------

Yes, it looks like this patch is based on an older revision, prior to 
SOLR-4208. Most of the things that are suggested here were implemented and 
committed. 
I didn't add a "preProecessUserQuery(...)", I thought about this, but I think 
now it is something easier to extend now (either wrapping the parse method, 
overriding the "getString()" method, when parsing the configuration, when 
getting the different clauses, depending on the needs). I didn't thought it was 
necessary to add an empty hook for this.
                
> ExtendedDismaxQParser should allow for extension of parsing-related behavior
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-3039
>                 URL: https://issues.apache.org/jira/browse/SOLR-3039
>             Project: Solr
>          Issue Type: Improvement
>          Components: query parsers
>    Affects Versions: 5.0
>            Reporter: Danny Dvinov
>            Priority: Minor
>              Labels: edismax, parser, parsing
>             Fix For: 5.0
>
>         Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, 
> SOLR-3039.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> ExtendedDismaxQParser.parse does not currently allow for things like query 
> pre-processing prior to its parsing, specifying the parser to be used, and 
> whether particular clause should be included in the query being parsed. 
> Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot 
> be subclassed. By resolving this issue, we'll provide a way for Solr 
> implementations to extend the parser and parsing related behavior.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to