[ 
https://issues.apache.org/jira/browse/SOLR-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554325#comment-13554325
 ] 

Erick Erickson commented on SOLR-4300:
--------------------------------------

OK, I'm going to commit this this evening or tomorrow morning for both trunk, 
4.1 & 4.x unless there are objections. I'll take another detailed pass over the 
code before I do on the theory that anything stupid will be clearer after not 
looking at it for a while.

My fears of deadlock are probably overblown. People don't _get_ to the code in 
question unless they're defining lazily-loaded cores, so "It shouldn't affect 
anyone not using the new functionality" (tm).


                
> Possible race condition in CoreContainer.getCore() when lazily loading cores.
> -----------------------------------------------------------------------------
>
>                 Key: SOLR-4300
>                 URL: https://issues.apache.org/jira/browse/SOLR-4300
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.1, 5.0
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Blocker
>         Attachments: SOLR-4300.patch
>
>
> Yonik pointed out in SOLR-1028 that there is a possible race condition here, 
> he's right not to my surprise. Calling it a "blocker" for now so we make a 
> decision on it rather than let it fall through the cracks. I should be able 
> to get a patch up tonight (Sunday).
> That said, there's potential here to introduce deadlocks, is it worth rushing 
> into 4.1?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to