Karl Wright created SOLR-4327:
---------------------------------

             Summary: SolrJ code review indicates potential for leaked 
HttpClient connections
                 Key: SOLR-4327
                 URL: https://issues.apache.org/jira/browse/SOLR-4327
             Project: Solr
          Issue Type: Bug
    Affects Versions: 4.0
            Reporter: Karl Wright


The SolrJ HttpSolrServer implementation does not seem to handle errors properly 
and seems capable of leaking HttpClient connections.  See the request() method 
in org.apache.solr.client.solrj.impl.HttpSolrServer.  The issue is that 
exceptions thrown from within this method do not necessarily consume the stream 
when an exception is thrown.  There is a try/finally block which reads (in 
part):

{code}
    } finally {
      if (respBody != null && processor!=null) {
        try {
          respBody.close();
        } catch (Throwable t) {} // ignore
      }
    }
{code}

But, in order to always guarantee consumption of the stream, it should include:

{code}
method.abort();
{code}



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to