David Smiley created LUCENE-4698:
------------------------------------

             Summary: Overhaul ShapeFieldCache because its a memory pig
                 Key: LUCENE-4698
                 URL: https://issues.apache.org/jira/browse/LUCENE-4698
             Project: Lucene - Core
          Issue Type: Improvement
          Components: modules/spatial
            Reporter: David Smiley


The org.apache.lucene.spatial.util.ShapeFieldCache* classes together implement 
a spatial field cache for points, similar to FieldCache for other fields.  It 
supports a variable number of points per document, and it's currently only used 
by the SpatialPrefixTree strategy because that's the only strategy that 
supports a variable number of points per document.  The other spatial 
strategies use the FieldCache.  The ShapeFieldCache has problems:
* It's a memory pig. Each point is stored as a Point object, instead of an 
array of x & y coordinates. Furthermore, each Point is in an ArrayList that 
exists for each Document. It's not done any differently when your spatial data 
isn't multi-valued.
* The cache is not per-segment, it's per-IndexReader, thereby making it 
un-friendly to NRT search.
* The cache entries don't self-expire optimally to free up memory. The cache is 
simply stored in a WeakHashMap<IndexReader,ShapeFieldCache>. The big cache 
entries are only freed when the WeakHashMap is used and the JVM realizes the 
IndexSearcher instance has been GC'ed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to