[ 
https://issues.apache.org/jira/browse/SOLR-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tricia Jenkins updated SOLR-4317:
---------------------------------

    Attachment: SOLR-4317.patch

Added test which uses multicore example.  Also further modified TestHarness and 
SolrTestCase4J to use coreName in creating core.  Didn't make any changes to 
ant scripts so the test isn't called during a normal build.
                
> SolrTestCaseJ4: Can't avoid "collection1" convention
> ----------------------------------------------------
>
>                 Key: SOLR-4317
>                 URL: https://issues.apache.org/jira/browse/SOLR-4317
>             Project: Solr
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 4.0
>            Reporter: Tricia Jenkins
>            Priority: Minor
>             Fix For: 4.2, 5.0
>
>         Attachments: SOLR-4317.patch, SOLR-4317.patch
>
>
> I think that there is still an issue after the SOLR-3826 patch was applied 
> for 4.0 [https://issues.apache.org/jira/browse/SOLR-3826] in September 2012.  
> This line is missing:
> Index: solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
> ===================================================================
> --- solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java    
> (revision 1435375)
> +++ solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java    
> (working copy)
> @@ -384,9 +384,9 @@
>    public static void createCore() {
>      assertNotNull(testSolrHome);
>      solrConfig = TestHarness.createConfig(testSolrHome, coreName, 
> getSolrConfigFile());
> -    h = new TestHarness( dataDir.getAbsolutePath(),
> +    h = new TestHarness( coreName, new Initializer( coreName, 
> dataDir.getAbsolutePath(),
>              solrConfig,
> -            getSchemaFile());
> +            getSchemaFile() ) );
>      lrf = h.getRequestFactory
>              ("standard",0,20,CommonParams.VERSION,"2.2");
>    }
> TestHarness( String dataDirectory,SolrConfig solrConfig, IndexSchema 
> indexSchema) sets coreName to null and opens the default core: collection1.  
> I would expect that coreName is carried all the way through the test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to