[ 
https://issues.apache.org/jira/browse/LUCENE-4724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated LUCENE-4724:
-------------------------------

    Attachment: LUCENE-4724.patch

Patch forbids empty or null components in CategoryPath ctors, plus matching 
test in TestCategoryPath. Mike, the test you added seems unneeded now, as one 
cannot create such a CP anymore.

Note though that there was a test in TestCP which asserted an empty path 
component in the middle of a string. I think it's not an interesting use case, 
and still should not be allowed.

I also had to modify another test which randomly generated CategoryPath strings 
(picking characters at random).
                
> TaxonomyReader drops empty string component from CategoryPath
> -------------------------------------------------------------
>
>                 Key: LUCENE-4724
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4724
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/facet
>            Reporter: Michael McCandless
>             Fix For: 4.2, 5.0
>
>         Attachments: LUCENE-4724.patch, LUCENE-4724.patch, LUCENE-4724.patch
>
>
> I ran the new PrintTaxonomyStats on a Wikipedia facets index, and it hit an 
> AIOOBE because there was a child of the /categories path that had only one 
> component ... this was created because I had added new 
> CategoryPath("categories", "") during indexing.
> I think TaxoReader should preserve and return that empty string from .getPath?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to