[ 
https://issues.apache.org/jira/browse/LUCENE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shai Erera updated LUCENE-4764:
-------------------------------

    Attachment: LUCENE-4764.patch

Patch handles some nocommits. Now Facet42Codec takes a FacetIndexingParams and 
builds a HashSet over the fields returned by fip.getAllCLPs(), and uses it in 
getDVFForField.

Also, this codec cannot support facet partitions, since the number of 
partitions is unknown in advance (each partition corresponds to a field). So I 
throw an IllegalArgEx.

I renamed the package to o.a.l.facet.codecs.facet42 and moved everything under 
it. Facet42Codec and Facet42DVF are the only public classes.

I also added a resources folder which declares the new DVF.

Made FacetTestCase randomly select the new codec (30% of the times), all tests 
pass. Note though that only tests that use the default FacetIndexingParams 
actually test the new format.

There are still few nocommits. I ran 'documetnation-lint' and it was happy.
                
> Faster but more RAM/Disk consuming DocValuesFormat for facets
> -------------------------------------------------------------
>
>                 Key: LUCENE-4764
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4764
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.2, 5.0
>
>         Attachments: LUCENE-4764.patch, LUCENE-4764.patch
>
>
> The new default DV format for binary fields has much more
> RAM-efficient encoding of the address for each document ... but it's
> also a bit slower at decode time, which affects facets because we
> decode for every collected docID.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to