[ 
https://issues.apache.org/jira/browse/LUCENE-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576652#comment-13576652
 ] 

Shai Erera commented on LUCENE-4764:
------------------------------------

You're right. I was just thinking ... until we need to do that, it can be 
final. But it can also be not final ...

I'm still not sure what's the best (or common) way to work w/ Codecs. When do 
you create your own FilterCodec and override the relevant method, and when are 
you expected to extend another Codec?

I guess that in this case, since getDVFForField is only on Lucene42Codec, you 
cannot really extend FilterCodec, so extending Lucene42 / Facet42 is the only 
option?

In short, I don't mind if it's not final :).
                
> Faster but more RAM/Disk consuming DocValuesFormat for facets
> -------------------------------------------------------------
>
>                 Key: LUCENE-4764
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4764
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.2, 5.0
>
>         Attachments: LUCENE-4764.patch, LUCENE-4764.patch, LUCENE-4764.patch
>
>
> The new default DV format for binary fields has much more
> RAM-efficient encoding of the address for each document ... but it's
> also a bit slower at decode time, which affects facets because we
> decode for every collected docID.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to