[ 
https://issues.apache.org/jira/browse/LUCENE-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580099#comment-13580099
 ] 

Steve Rowe commented on LUCENE-4570:
------------------------------------

I wondered how much time running ForbiddenAPI checker, executed multiple times 
in each of ~40 modules, adds to the Maven build, so I ran {{mvn \-DskipTests 
install}}, and then {{mvn process-test-classes}}, both pre- and post-patch.  
This excludes performing compilation, since I didn't {{mvn clean}} inbetween.

On my Macbook pro, with Oracle Java 1.7.0_13 and Maven 3.0.3, the best 
(fastest) of five runs of {{mvn process-test-classes}} for pre-patch: 20s.  
Best of five for post-patch: 22s.  So it looks like this adds 2 seconds to 
build time, assuming a populated OS filesystem cache.

If I use [{{sudo 
purge}}|http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man8/purge.8.html]
 to clear the OS filesystem cache before every run, pre-patch best of five runs 
still took 20s, but post-patch best of five took 26s.  So with an empty OS 
filesystem cache, this adds 6 seconds to the build time. 

I think this slowdown is live-with-able.

Committing now.

                
> Release ForbiddenAPI checker on Google Code
> -------------------------------------------
>
>                 Key: LUCENE-4570
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4570
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: general/build
>            Reporter: Robert Muir
>            Assignee: Uwe Schindler
>             Fix For: 4.2, 5.0
>
>         Attachments: LUCENE-4570-maven-inherited.patch, 
> LUCENE-4570-maven-inherited.patch, LUCENE-4570-maven.patch, 
> LUCENE-4570-maven.patch, LUCENE-4570.patch, LUCENE-4570.patch, 
> LUCENE-4570.patch, LUCENE-4570.patch, LUCENE-4570.patch
>
>
> Currently there is source code in lucene/tools/src (e.g. Forbidden APIs 
> checker ant task).
> It would be convenient if you could download this thing in your ant build 
> from ivy (especially if maybe it included our definitions .txt files as 
> resources).
> In general checking for locale/charset violations in this way is a pretty 
> general useful thing for a server-side app.
> Can we either release lucene-tools.jar as an artifact, or maybe alternatively 
> move this somewhere else as a standalone project and suck it in ourselves?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to