[
https://issues.apache.org/jira/browse/LUCENE-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585339#comment-13585339
]
Shai Erera commented on LUCENE-4748:
------------------------------------
Great work Mike!
Few comments:
* The CHANGES line should not remove 'static methods' right?
* Can you add jdoc to FA.create(), something like "returns FA if all requests
are CountFR, StandardFA otherwise"?
** And while on that, fix FacetsCollector.create to say "calls create(FA) by
creating FA using FA.create" ... something like that
* This "// TODO: remove this limitation: it's silly?" -- can we handle it now?
It's odd that we add a 'silly' limitation :). If we don't want the app to do
it, then just throw the exception, and remove the TODO. Otherwise allow it?
** Same goes for this "// TODO: remove this limitation (allow pure browse".
** Unless, it's not easy to handle these TODOs now.
* This "for(int i=0;i<fsp.facetRequests.size();i++) {" can be converted to Java
5-style iteration?
* getDrillDown/SidewaysAccumulator -- should the jdoc say "Override ... how the
FA is created"? Or maybe "Override to use a custom FA by FacetsCollector"?
Other than that, +1 to commit!
> Add DrillSideways helper class to Lucene facets module
> ------------------------------------------------------
>
> Key: LUCENE-4748
> URL: https://issues.apache.org/jira/browse/LUCENE-4748
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.2, 5.0
>
> Attachments: DrillSideways-alternative.tar.gz, LUCENE-4748.patch,
> LUCENE-4748.patch, LUCENE-4748.patch, LUCENE-4748.patch, LUCENE-4748.patch,
> LUCENE-4748.patch, LUCENE-4748.patch, LUCENE-4748.patch, LUCENE-4748.patch
>
>
> This came out of a discussion on the java-user list with subject
> "Faceted search in OR": http://markmail.org/thread/jmnq6z2x7ayzci5k
> The basic idea is to count "near misses" during collection, ie
> documents that matched the main query and also all except one of the
> drill down filters.
> Drill sideways makes for a very nice faceted search UI because you
> don't "lose" the facet counts after drilling in. Eg maybe you do a
> search for "cameras", and you see facets for the manufacturer, so you
> drill into "Nikon".
> With drill sideways, even after drilling down, you'll still get the
> counts for all the other brands, where each count tells you how many
> hits you'd get if you changed to a different manufacturer.
> This becomes more fun if you add further drill-downs, eg maybe I next drill
> down into Resolution=10 megapixels", and then I can see how many 10
> megapixel cameras all other manufacturers, and what other resolutions
> Nikon cameras offer.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
