[ 
https://issues.apache.org/jira/browse/SOLR-3843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586388#comment-13586388
 ] 

Robert Muir commented on SOLR-3843:
-----------------------------------

Thanks Steve: I was actually (and still am i think) uncertain who should have 
the dependency.

If you think about it, its no different than the analysis module cases: but i 
don't see the webapp depending on them here.

At the moment, i understand the reasoning behind the hard dependency to 
analysis-common.jar (because bogusly the factory stuff is there, imo it should 
not be).

But somewhere in maven, something in solr depends on the other analysis modules 
it bundles (e.g. analyzers-phonetic), yet you could remove this jar and solr 
would work fine (as long as you didnt use these particular phonetic analyzers).

So I feel like these analysis components (except common, see above), along with 
codecs.jar, should be depended on in the same place. I guess theoretically they 
are optional dependencies but I don't think we should do that (unless we test 
every possibility with/without optional X,Y,Z, so I think its a bad idea). But 
they are the same in this sense.
                
> Add lucene-codecs to Solr libs?
> -------------------------------
>
>                 Key: SOLR-3843
>                 URL: https://issues.apache.org/jira/browse/SOLR-3843
>             Project: Solr
>          Issue Type: Wish
>    Affects Versions: 4.0
>            Reporter: Adrien Grand
>            Priority: Critical
>             Fix For: 4.2, 5.0
>
>         Attachments: SOLR-3843.patch, SOLR-3843.patch
>
>
> Solr gives the ability to its users to select the postings format to use on a 
> per-field basis but only Lucene40PostingsFormat is available by default 
> (unless users add lucene-codecs to the Solr lib directory). Maybe we should 
> add lucene-codecs to Solr libs (I mean in the WAR file) so that people can 
> try our non-default postings formats with minimum effort?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to