Hoss Man created SOLR-4514:
------------------------------

             Summary: Need tests for OpenExchangeRatesOrgProvider
                 Key: SOLR-4514
                 URL: https://issues.apache.org/jira/browse/SOLR-4514
             Project: Solr
          Issue Type: Improvement
            Reporter: Hoss Man


the schema.xml used by CurrencyFieldTest declares a fieldType named 
"openexchangeratesorg_currency" using OpenExchangeRatesOrgProvider pointed at a 
local copy of open-exchange-rates.json, but field type is completley unused, so 
nothing about this provider's behavior is ever really tested.

We should change the test such that all of the functionality tested against the 
"amount" field is also tested against some new field using this OER provider 
based fieldType, where the copied data (and static exchange rates) are 
identical.

(esasiest way would probably be to introduce a test variable for the field name 
and let a new subclass override it)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to