[
https://issues.apache.org/jira/browse/SOLR-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-4514:
---------------------------
Attachment: SOLR-4514.patch
one aspect specific to the xml file provider is that it supports asymetrical
conversion rates -- so i refactored a new AbstractCurrencyField test for the
common stuff, put the test for the asymetric conversion in a subclass that uses
the "amount" field and added another subclasses that uses a new "oer_amount"
field.
i also updated the (stale) open-exchange-rates.json file to have rates that
match the (symetric) rates from currency.xml so the tests would all pass
regardless of which file is used
> Need tests for OpenExchangeRatesOrgProvider
> -------------------------------------------
>
> Key: SOLR-4514
> URL: https://issues.apache.org/jira/browse/SOLR-4514
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Attachments: SOLR-4514.patch
>
>
> the schema.xml used by CurrencyFieldTest declares a fieldType named
> "openexchangeratesorg_currency" using OpenExchangeRatesOrgProvider pointed at
> a local copy of open-exchange-rates.json, but field type is completley
> unused, so nothing about this provider's behavior is ever really tested.
> We should change the test such that all of the functionality tested against
> the "amount" field is also tested against some new field using this OER
> provider based fieldType, where the copied data (and static exchange rates)
> are identical.
> (esasiest way would probably be to introduce a test variable for the field
> name and let a new subclass override it)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
