[ 
https://issues.apache.org/jira/browse/LUCENE-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592740#comment-13592740
 ] 

David Smiley commented on LUCENE-3459:
--------------------------------------

Ha!  I was just about to report the reverse problem -- make TermsFilter return 
OpenBitset for optimal compatibility with ChainedFilter.  I'm using 
TermsFilters with ChainedFilter and the mis-match of OpenBitSet and FixedBitSet 
is definitely not optimal since I want it to intersect those bitsets together 
quickly.

I don't understand why there are both.  My IDE says FixedBitSet has 206 usages 
compared to OpenBitSet's 230.  That's closer than I thought.  I recall 
[~thetaphi‍] saying he would like OBS deprecated, but I pointed out that it is 
OBS that is fully public and FixedBitSet that is marked as @lucene.internal.
                
> Change ChainedFilter to use FixedBitSet
> ---------------------------------------
>
>                 Key: LUCENE-3459
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3459
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: modules/other
>    Affects Versions: 3.4, 4.0-ALPHA
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 4.2
>
>
> ChainedFilter also uses OpenBitSet(DISI) at the moment. It should also be 
> changed to use FixedBitSet. There are two issues:
> - It exposes sometimes OpenBitSetDISI to it's public API - we should remove 
> those methods like in BooleanFilter and break backwards
> - It allows a XOR operation. This is not yet supported by FixedBitSet, but 
> it's easy to add (like for BooleanFilter). On the other hand, this XOR 
> operation is bogus, as it may mark documents in the BitSet that are deleted, 
> breaking new features like applying Filters down-low (LUCENE-1536). We should 
> remove the XOR operation maybe or force it to use IR.validDocs() (trunk) or 
> IR.isDeleted()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to