[
https://issues.apache.org/jira/browse/SOLR-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594096#comment-13594096
]
Hoss Man commented on SOLR-4329:
--------------------------------
bq. I find your chief/only concern odd: buggy code is by definition buggy and
unsurprisingly could wreak havoc. And if rogue untrusted code is getting into
your app then I think you're screwed. But, I think in a nutshell you're saying
this is perhaps too much flexibility to hang yourself with.
Agreed, Buggy code is buggy code, and it should not be surprising if buggy code
wreaks havoc. My concern is not so much that this much flexibility makes it
easier for a FieldType to hang itself -- I'm ok with advanced APIs making it
easy to write broken plugins as long as Solr gives good visibility/exceptions
about how the plugin is broken.
My concern is that this much flexibility makes it easy for a FieldType to hang
a _different_ FieldType, w/o any clear indication that such action at a
distance has taken place, making it hard to track down what happened or where.
bq. For example, honestly my use-cases don't need the entire SolrInputDocument
... Nor do my use-cases actually require the Lucene Document, ...
I'm not picky on the details, but if you see a clear way to:
# achieve what's needed for all the use cases you can think of at the moment
# limit the exposure of the Document internals so that DocumentBuilder's
delegation to the FieldType doesn't let it muck with other fields
..then that sounds like win to me.
> Have DocumentBuilder give value collections to the FieldType
> ------------------------------------------------------------
>
> Key: SOLR-4329
> URL: https://issues.apache.org/jira/browse/SOLR-4329
> Project: Solr
> Issue Type: New Feature
> Components: update
> Reporter: David Smiley
> Assignee: David Smiley
> Fix For: 4.2
>
> Attachments: DocumentBuilder.java
>
>
> I'd like to write a multi-value-configured FieldType that can return a
> DocValue Field from its createFields(). Since DocValues holds a single value
> per document for a field, you can only have one. However
> FieldType.createFields() is invoked by the DocumentBuilder once per each
> value being indexed.
> FYI the reason I'm asking for this is for a multi-valued spatial field to
> store its points in DocValues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
