[ 
https://issues.apache.org/jira/browse/LUCENE-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan Lauck updated LUCENE-4734:
-------------------------------

    Attachment: lucene-4734.patch

Store the max possible slop on the QueryPhraseMap rather than the entire 
FieldQuery. This limits unnecessary matching when a PhraseQuery with a large 
slop is combined with other PhraseQuerys.

Also, I added a fragment of slop recalculation code from 
WeightedSpanTermExtractor that handles PhraseQuerys with position gaps. The 
most common way this is encountered is by searching a phrase that contains stop 
words while using an analyzer that filters them.

Also cleaned up the test cases a little, and added a few comments. 
                
> FastVectorHighlighter Overlapping Proximity Queries Do Not Highlight
> --------------------------------------------------------------------
>
>                 Key: LUCENE-4734
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4734
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/highlighter
>    Affects Versions: 4.0, 4.1, 5.0
>            Reporter: Ryan Lauck
>              Labels: fastvectorhighlighter, highlighter
>             Fix For: 4.2, 5.0
>
>         Attachments: lucene-4734.patch, lucene-fvh-slop.patch, 
> lucene-fvh-slop-reverse.patch
>
>
> If a proximity phrase query overlaps with any other query term it will not be 
> highlighted.
> Example Text:  A B C D E F G
> Example Queries: 
> "B E"~10 D
> (D will be highlighted instead of "B C D E")
> "B E"~10 "C F"~10
> (nothing will be highlighted)
> This can be traced to the FieldPhraseList constructor's inner while loop. 
> From the first example query, the first TermInfo popped off the stack will be 
> "B". The second TermInfo will be "D" which will not be found in the submap 
> for "B E"~10 and will trigger a failed match.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to