[ 
https://issues.apache.org/jira/browse/SOLR-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13594852#comment-13594852
 ] 

Joel Bernstein edited comment on SOLR-4465 at 3/6/13 5:24 PM:
--------------------------------------------------------------

New patch with a couple of additions:

1) Added code during initialization of the collectorFactories to handle 
condition where default collectorFactory is not defined in solrconfig.xml. This 
makes this patch backwords compatible with 4.* solrconfigs.

Tests now run without null pointers.

2) Added the CollectorSpec class to hold the collector http parameters. This 
class will implement hashCode and equals and will be added to QueryResultKey. 
The QueryResultKey implementation of this is not in this patch so more work 
still needs be done on getting this cache ready.

This patch has been tested with the default collector factory with sorting and 
ranking queries and in distributed mode.
                
      was (Author: joel.bernstein):
    New patch with a couple of additions:

1) Added code during initialization of the collectorFactories to handle 
condition where default collectorFactory is not defined in solrconfig.xml. This 
makes this patch backwords compatible with 4.* solrconfigs.

Tests now run without null pointers.

2) Added the CollectorSpec class to hold the collector http parameters. This 
class will implement hashCode and equals and will be added to QueryResultKey. 
The QueryResultKey implementation of this is not in this patch so more work 
still needs be done on getting this cache ready.

I have tested this patch with the default collector factory with sorting and 
ranking queries and in distributed mode.
                  
> Configurable Collectors
> -----------------------
>
>                 Key: SOLR-4465
>                 URL: https://issues.apache.org/jira/browse/SOLR-4465
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 4.1
>            Reporter: Joel Bernstein
>             Fix For: 4.2, 5.0
>
>         Attachments: SOLR-4465.patch, SOLR-4465.patch, SOLR-4465.patch, 
> SOLR-4465.patch, SOLR-4465.patch, SOLR-4465.patch, SOLR-4465.patch, 
> SOLR-4465.patch, SOLR-4465.patch, SOLR-4465.patch
>
>
> This issue is to add configurable custom collectors to Solr. This expands the 
> design and work done in issue SOLR-1680 to include:
> 1) CollectorFactory configuration in solconfig.xml
> 2) Http parameters to allow clients to dynamically select a CollectorFactory 
> and construct a custom Collector.
> 3) Make aspects of QueryComponent pluggable so that the output from 
> distributed search can conform with custom collectors at the shard level.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to