[ 
https://issues.apache.org/jira/browse/LUCENE-4819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir reopened LUCENE-4819:
---------------------------------


This caused solr test failures.

I've reverted for now. I'll figure out whats wrong (and why lucene tests didnt 
catch it). But for now I'm trying to release.
                
> move Sorted[Set]DocValuesTermsEnum to codec
> -------------------------------------------
>
>                 Key: LUCENE-4819
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4819
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>            Reporter: Robert Muir
>             Fix For: 5.0, 4.3
>
>         Attachments: LUCENE-4819.patch
>
>
> Currently a user can instantiate a SortedDocValuesTermsEnum(SortedDocValues). 
> This is a generic termsenum, implementing all operations by lookupOrd().
> I think instead this should be the default implementation, and we should have 
> e.g. SortedDocValues.termsEnum() that returns it (codec can implement 
> something fancier).
> For example the default codec implements lookupOrd as an FST binary search, 
> which means next() on this termsenum is much slower than it needs to be for 
> the places where this enum is actually used (segment merging, OrdinalMap used 
> for faceting in SOLR-4490 and LUCENE-4795) 
> So instead, it can override this method and use an FSTEnum, and these 
> operations are significantly faster (3x faster for me with a simple benchmark 
> with 10M terms).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to